tower: prepare to release 0.4.10 #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
approved these changes
Oct 19, 2021
jplatte
reviewed
Oct 19, 2021
| authors = ["Tower Maintainers <[email protected]>"] | ||
| license = "MIT" | ||
| readme = "README.md" | ||
| repository = "https://github.com/tower-rs/tower" | ||
| homepage = "https://github.com/tower-rs/tower" | ||
| documentation = "https://docs.rs/tower/0.4.9" | ||
| documentation = "https://docs.rs/tower/0.4.10" |
There was a problem hiding this comment.
Like http_root_url, this is also not required 😄
(if you don't see the documentation link on some pages, you're most likely blocking the docs.rs JS script that adds them for crates that don't explicitly set this field)
There was a problem hiding this comment.
Do you wanna do a PR that cleans up this stuff? I believe you made one for Axum as well back in the days. That would be awesome 😊
There was a problem hiding this comment.
I removed up html_root_url in #603, will add another PR that removes this link (after this PR is merged and I do the necessary rebase).
|
@jplatte yeah but I kinda wanna get this out asap I'm having dinner in town but will merge and publish when I'm back, unless someone beats me to it. |
Co-authored-by: Oliver Gould <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustdoc::broken_intra_doc_linkslint (#605)